Module Name: src
Committed By: kre
Date: Fri Aug 3 12:49:41 UTC 2018
Modified Files:
src/crypto/external/bsd/openssh/dist: sshkey.c
Log Message:
Add a "gcc is stupid" comment to the previous change, as even
the most cursory analysis shows that the var ("eg") is not (cannot
be) used unitialialised, just gcc is too dumb to work it out.
In this case, the code could be rewritten easily enough to
appease even gcc, but that would cause unnecessary code churn,
and some minor duplication, so just put up with the nonsense init...
To generate a diff of this commit:
cvs rdiff -u -r1.15 -r1.16 src/crypto/external/bsd/openssh/dist/sshkey.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/crypto/external/bsd/openssh/dist/sshkey.c
diff -u src/crypto/external/bsd/openssh/dist/sshkey.c:1.15 src/crypto/external/bsd/openssh/dist/sshkey.c:1.16
--- src/crypto/external/bsd/openssh/dist/sshkey.c:1.15 Fri Aug 3 04:32:12 2018
+++ src/crypto/external/bsd/openssh/dist/sshkey.c Fri Aug 3 12:49:41 2018
@@ -1,4 +1,4 @@
-/* $NetBSD: sshkey.c,v 1.15 2018/08/03 04:32:12 kamil Exp $ */
+/* $NetBSD: sshkey.c,v 1.16 2018/08/03 12:49:41 kre Exp $ */
/* $OpenBSD: sshkey.c,v 1.64 2018/03/22 07:05:48 markus Exp $ */
/*
* Copyright (c) 2000, 2001 Markus Friedl. All rights reserved.
@@ -26,7 +26,7 @@
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include "includes.h"
-__RCSID("$NetBSD: sshkey.c,v 1.15 2018/08/03 04:32:12 kamil Exp $");
+__RCSID("$NetBSD: sshkey.c,v 1.16 2018/08/03 12:49:41 kre Exp $");
#include <sys/types.h>
#include <netinet/in.h>
@@ -1641,7 +1641,7 @@ dsa_generate_private_key(u_int bits, DSA
int
sshkey_ecdsa_key_to_nid(EC_KEY *k)
{
- EC_GROUP *eg = NULL;
+ EC_GROUP *eg = NULL; /* XXXGCC: unneeded init */
int nids[] = {
NID_X9_62_prime256v1,
NID_secp384r1,
