Module Name: src Committed By: rillig Date: Sat Aug 8 13:27:42 UTC 2020
Modified Files: src/usr.bin/make: var.c src/usr.bin/make/unit-tests: moderrs.exp moderrs.mk varmod-edge.exp Log Message: make(1): improve error message in case of unfinished modifiers The previous error message "Unclosed substitution" was wrong for several reasons. It is not about "unclosed", but about "unfinished" since in the :@var@...@ modifier the missing '@' does not really close anything. The word "substitution" may have originated in a time where :S and :from=to were the only modifiers, and these were indeed substitutions, but several other modifiers aren't. The :S and :C modifiers allow an arbitrary delimiter, therefore it is helpful to enclose the delimiter in quotes, just in case someone chooses ')' or '{' or even ' ' as delimiter. To generate a diff of this commit: cvs rdiff -u -r1.427 -r1.428 src/usr.bin/make/var.c cvs rdiff -u -r1.12 -r1.13 src/usr.bin/make/unit-tests/moderrs.exp cvs rdiff -u -r1.11 -r1.12 src/usr.bin/make/unit-tests/moderrs.mk cvs rdiff -u -r1.7 -r1.8 src/usr.bin/make/unit-tests/varmod-edge.exp Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.