Module Name: src
Committed By: snj
Date: Sat Feb 10 04:12:17 UTC 2018
src/sys/dist/pf/net [netbsd-8]: pf.c
Pull up following revision(s) (requested by maxv in ticket #540):
PR/52682: David Binderman: Fix wrong assignment (in the !__NetBSD__ code)
Oh, what is this. Fix a remotely-triggerable integer overflow: the way we
define TCPOLEN_SACK makes it unsigned, and the comparison in the while()
is unsigned too. That's not the expected behavior, the original code
wanted a signed comparison.
It's pretty easy to make 'hlen' go negative and trigger a buffer overflow.
This bug was reported 8 years ago by Lucio Albornoz in PR/44059.
To generate a diff of this commit:
cvs rdiff -u -r1.76 -r126.96.36.199 src/sys/dist/pf/net/pf.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.