Module Name:    src
Committed By:   maxv
Date:           Sat Apr  7 09:20:25 UTC 2018

Modified Files:
        src/sys/net/npf: npf_ext_normalize.c

Log Message:
Fix an inverted logic.

nbuf_cksum_barrier returns true when the direction is PFIL_OUT and TSO is
active; that is to say, it returns true when the checksum was already
recomputed by the function.

The check should be !nbuf_cksum_barrier, because otherwise we're wrongfully
checksumming twice, and it causes the packet to be kicked later in

This can be seen with a configuration of the type:

        procedure "norm" {
                normalize: "max-mss" 15000
        group default {
                pass all apply "norm"

The packets systematically get dropped because the checksum validation in
tcp_input fails. With this patch in place, it works.

To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 src/sys/net/npf/npf_ext_normalize.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Reply via email to