On Tue, 23 Oct 2018 23:19:03 -0600 (MDT), Ori Bernstein <o...@openbsd.org>
wrote:
> CVSROOT: /cvs
> Module name: src
> Changes by: o...@cvs.openbsd.org 2018/10/23 23:19:03
>
> Modified files:
> usr.sbin/vmd : vioqcow2.c
>
> Log message:
> Fix qcow2 disk images for data sizes greater than 4 gigs.
>
> We used to truncate the disk end by anding it with a 32 bit value.
> The 32 bit value was not sign extended, which causes the disk size
> to wrap at 4 gigabytes:
>
> disk->end = (disk->end + disk->clustersz - 1) & ~(disk->clustersz - 1);
>
> This change converts the clustersz to an off_t in order to remove the
> class of errors by avoiding type conversions entirely.
>
Oops: Forgot -- this was OK mlarkin@ and reyk@
--
Ori Bernstein
