On Thu, Oct 21, 2021 at 04:59:08PM -0600, Tobias Heider wrote:
> CVSROOT:      /cvs
> Module name:  src
> Changes by:   [email protected]   2021/10/21 16:59:08
> 
> Modified files:
>       sys/netinet    : ip_ah.c ip_esp.c ip_ipcomp.c 
>       sys/crypto     : crypto.c cryptodev.h 
> 
> Log message:
> Remove code to run crypto operations in a task queue. The code was
> not reachable because all callers had set the CRYPTO_F_NOQUEUE flag.
> 
> ok patrick@ mvs@ bluhm@

This commit broke the kernel.

Index: dev/softraid_crypto.c
===================================================================
RCS file: /cvs/src/sys/dev/softraid_crypto.c,v
retrieving revision 1.142
diff -u -p -r1.142 softraid_crypto.c
--- dev/softraid_crypto.c       13 Oct 2021 22:43:44 -0000      1.142
+++ dev/softraid_crypto.c       22 Oct 2021 04:48:06 -0000
@@ -325,7 +325,7 @@ sr_crypto_prepare(struct sr_workunit *wu
        crwu->cr_crp->crp_opaque = crwu;
        crwu->cr_crp->crp_ilen = xs->datalen;
        crwu->cr_crp->crp_alloctype = M_DEVBUF;
-       crwu->cr_crp->crp_flags = CRYPTO_F_IOV | CRYPTO_F_NOQUEUE;
+       crwu->cr_crp->crp_flags = CRYPTO_F_IOV;
        crwu->cr_crp->crp_buf = &crwu->cr_uio;
        for (i = 0; i < crwu->cr_crp->crp_ndesc; i++, blkno++) {
                crd = &crwu->cr_crp->crp_desc[i];

Reply via email to