On Thu, Nov 25, 2021 at 03:02:25PM -0500, Dave Voutila wrote: > Anton Lindqvist <an...@cvs.openbsd.org> writes: > > > CVSROOT: /cvs > > Module name: src > > Changes by: an...@cvs.openbsd.org 2021/11/24 23:25:32 > > > > Modified files: > > sys/dev/usb : uhidev.c > > > > Log message: > > Assert that at least one report id is claimed during multiple report ids > > attachment. Should prevent uhidev drivers from doing the wrong thing in > > their > > corresponding match routine. > > I think this is the commit that broke booting my Surface Go 2 with the > surface keyboard attached. The device panics with: > > panic: config_detach: detached device (uhidev3) has children > > Full panic and backtrace: https://imgur.com/a/xbYB7d3 > > No idea why this commit broke it...but I can use a snapshot from 24 > November without issue and if I backout this commit from my source tree > I don't have the issue. > > The surface keyboard does some strange attach detach attach cycle during > boot. I believe jcs@ had to add some interesting quirks for > umt(4)/ums(4) due to this?
An inverted conditional snuck in there, sorry about that. I just backed it out until I have time to properly test this.
