On Mon, Dec 13, 2021 at 09:56:50AM -0700, Theo de Raadt wrote:
> CVSROOT: /cvs
> Module name: src
> Changes by: [email protected] 2021/12/13 09:56:50
>
> Modified files:
> regress/lib/libc/basename: basename_test.c
> regress/lib/libc/db: dbtest.c
> regress/lib/libc/dirname: dirname_test.c
> regress/lib/libc/mkstemp: mkstemp_test.c
> regress/lib/libc/popen: popen.c
> regress/lib/libc/sys: macros.h t_access.c t_chroot.c
> t_clock_gettime.c t_dup.c t_fork.c
> t_fsync.c t_getgroups.c t_getitimer.c
> t_getlogin.c t_getpid.c t_getrusage.c
> t_getsid.c t_gettimeofday.c t_kevent.c
> t_kill.c t_link.c t_minherit.c t_mkdir.c
> t_mkfifo.c t_mknod.c t_mlock.c t_mmap.c
> t_msgctl.c t_msgget.c t_msgrcv.c
> t_msgsnd.c t_msync.c t_pipe.c t_pipe2.c
> t_ptrace.c t_revoke.c t_sendrecv.c
> t_setrlimit.c t_setuid.c t_sigaction.c
> t_sigaltstack.c t_socketpair.c t_stat.c
> t_syscall.c t_truncate.c t_umask.c
> t_unlink.c t_wait_noproc.c t_write.c
> regress/lib/libm/msun: cexp_test.c csqrt_test.c ctrig_test.c
> fma_test.c invctrig_test.c
> logarithm_test.c macros.h nan_test.c
> nearbyint_test.c trig_test.c
> regress/lib/libpthread/cwd: cwd.c
> regress/sbin/iked/parser: test_parser_fuzz.c
> regress/sbin/isakmpd/crypto: cryptotest.c
> regress/sbin/isakmpd/hmac: hmactest.c
> regress/sbin/isakmpd/prf: prftest.c
> regress/sbin/isakmpd/x509: x509test.c
> regress/sys/arch/amd64/dump_tables: dump_tables.c
> regress/sys/arch/amd64/fpu: fdfl.c fdump.c feget.c fxproc0.c
> regress/sys/arch/hppa/probe: probe.c
> regress/sys/arch/hppa/sfuid: sfuid.c
> regress/sys/copy: copy.c
> regress/sys/crypto/aes: aestest.c
> regress/sys/crypto/aesctr: aesctr.c
> regress/sys/crypto/chachapoly: chachapoly_test.c
> regress/sys/crypto/cmac: cmac_test.c
> regress/sys/crypto/enc: des3.c
> regress/sys/crypto/gmac: gmac_test.c
> regress/sys/ffs: fstest.c
> regress/sys/fifofs: fifotest.c
> regress/sys/kern/accept: accept.c
> regress/sys/kern/clock_gettime: monotonicrelapse.c
> regress/sys/kern/kqueue: kqueue-random.c
> regress/sys/kern/mbuf: mbuftest.c
> regress/sys/kern/noexec: noexec.c
> regress/sys/kern/pledge/ioctl: unfdpass.c
> regress/sys/kern/ptrace2: macros.h ptrace_test.c
> regress/sys/kern/rcvtimeo: rcvtimeo.c
> regress/sys/kern/setuid: setegid.c seteuid.c setgid.c
> setgid_child.c setgid_exec_inherit.c
> setgid_none.c setresgid.c
> setresgid_effective_exec.c
> setresgid_real_exec.c
> setresgid_saved_exec.c setresuid.c
> setresuid_effective_exec.c
> setresuid_real_exec.c
> setresuid_saved_exec.c setuid.c
> setuid_child.c setuid_exec_inherit.c
> setuid_none.c setuid_real_exec.c
> sgidexec.c sgidexec_inherit.c
> sgidexec_none.c suidexec.c
> suidexec_inherit.c suidexec_none.c
> regress/sys/kern/signal/cansig: cansig.c
> regress/sys/kern/sysvmsg: msgtest.c
> regress/sys/kern/sysvsem: semtest.c
> regress/sys/kern/sysvshm: shmtest.c
> regress/sys/kern/unfdpass: unfdpass.c
> regress/sys/kern/unveil: syscalls.c
> regress/sys/nfs: mmap-sysctl-copyin.c mmap-sysctl-copyout.c
> regress/sys/uvm/mmap_hint: mmap_hint.c
> regress/sys/uvm/wx_syscall: wx_syscall.c
>
> Log message:
> remove a couple hundred sys/param.h includes in userland code, and
> also whack some sys/cdefs.h early includes which is such a brutally
> bad pattern
> ok bluhm mbuhl
This broke a couple of tests. Should be easy to repair, can look into it
hopefully later today assuming noone beats me to it.
----------------------------- >8 -----------------------------
> stats:
Status: 4 failures
Duration: 02:45:21
Build: /home/regress/2021-12-14.1
> sys/crypto/chachapoly:
Exit: 1
Duration: 00:00:02
Log: 49-sys-crypto-chachapoly.log
+ . /usr/local/libexec/robsd/util.sh
+ . /usr/local/libexec/robsd/util-ports.sh
+ . /usr/local/libexec/robsd/util-regress.sh
+ regress_root sys/crypto/chachapoly
+ unpriv anton exec make -C /home/src/regress/sys/crypto/chachapoly
cc -O2 -pipe -I/home/src/regress/sys/crypto/chachapoly/../../../../sys -MD
-MP -c
/home/src/regress/sys/crypto/chachapoly/../../../../sys/crypto/poly1305.c
cc -O2 -pipe -I/home/src/regress/sys/crypto/chachapoly/../../../../sys -MD
-MP -c
/home/src/regress/sys/crypto/chachapoly/../../../../sys/crypto/chachapoly.c
cc -O2 -pipe -I/home/src/regress/sys/crypto/chachapoly/../../../../sys -MD
-MP -c /home/src/regress/sys/crypto/chachapoly/chachapoly_test.c
/home/src/regress/sys/crypto/chachapoly/chachapoly_test.c:331:24: warning:
implicit declaration of function 'MIN' is invalid in C99
[-Wimplicit-function-declaration]
memcpy(blk, aad + i, MIN(aadlen - i, POLY1305_BLOCK_LEN));
^
/home/src/regress/sys/crypto/chachapoly/chachapoly_test.c:336:14: warning:
implicit declaration of function 'MIN' is invalid in C99
[-Wimplicit-function-declaration]
int dlen = MIN(len - i, CHACHA20_BLOCK_LEN);
^
2 warnings generated.
cc -o chachapoly_test poly1305.o chachapoly.o chachapoly_test.o
ld: error: undefined symbol: MIN
>>> referenced by chachapoly_test.c
>>> chachapoly_test.o:(main)
>>> referenced by chachapoly_test.c
>>> chachapoly_test.o:(main)
cc: error: linker command failed with exit code 1 (use -v to see invocation)
*** Error 1 in /home/src/regress/sys/crypto/chachapoly (<bsd.prog.mk>:126
'chachapoly_test')
robsd-regress-exec: process group exited 2
> sys/crypto/gmac:
Exit: 1
Duration: 00:00:02
Log: 52-sys-crypto-gmac.log
+ . /usr/local/libexec/robsd/util.sh
+ . /usr/local/libexec/robsd/util-ports.sh
+ . /usr/local/libexec/robsd/util-regress.sh
+ regress_root sys/crypto/gmac
+ unpriv anton exec make -C /home/src/regress/sys/crypto/gmac
cc -O2 -pipe -I/home/src/regress/sys/crypto/gmac/../../../../sys -MD -MP -c
/home/src/regress/sys/crypto/gmac/../../../../sys/crypto/aes.c
cc -O2 -pipe -I/home/src/regress/sys/crypto/gmac/../../../../sys -MD -MP -c
/home/src/regress/sys/crypto/gmac/../../../../sys/crypto/gmac.c
cc -O2 -pipe -I/home/src/regress/sys/crypto/gmac/../../../../sys -MD -MP -c
/home/src/regress/sys/crypto/gmac/gmac_test.c
/home/src/regress/sys/crypto/gmac/gmac_test.c:653:24: warning: implicit
declaration of function 'MIN' is invalid in C99
[-Wimplicit-function-declaration]
memcpy(blk, aad + i, MIN(aadlen - i, GMAC_BLOCK_LEN));
^
/home/src/regress/sys/crypto/gmac/gmac_test.c:658:14: warning: implicit
declaration of function 'MIN' is invalid in C99
[-Wimplicit-function-declaration]
int dlen = MIN(len - i, GMAC_BLOCK_LEN);
^
2 warnings generated.
cc -o gmac_test aes.o gmac.o gmac_test.o
ld: error: undefined symbol: MIN
>>> referenced by gmac_test.c
>>> gmac_test.o:(main)
>>> referenced by gmac_test.c
>>> gmac_test.o:(main)
cc: error: linker command failed with exit code 1 (use -v to see invocation)
*** Error 1 in /home/src/regress/sys/crypto/gmac (<bsd.prog.mk>:126 'gmac_test')
robsd-regress-exec: process group exited 2
> sys/kern/kqueue:
Exit: 1
Duration: 00:00:01
Log: 90-sys-kern-kqueue.log
+ . /usr/local/libexec/robsd/util.sh
+ . /usr/local/libexec/robsd/util-ports.sh
+ . /usr/local/libexec/robsd/util-regress.sh
+ regress_root sys/kern/kqueue
+ unpriv anton exec make -C /home/src/regress/sys/kern/kqueue
cc -O2 -pipe -Wall -MD -MP -c /home/src/regress/sys/kern/kqueue/kqueue-pipe.c
cc -O2 -pipe -Wall -MD -MP -c /home/src/regress/sys/kern/kqueue/kqueue-fork.c
cc -O2 -pipe -Wall -MD -MP -c /home/src/regress/sys/kern/kqueue/main.c
cc -O2 -pipe -Wall -MD -MP -c
/home/src/regress/sys/kern/kqueue/kqueue-process.c
cc -O2 -pipe -Wall -MD -MP -c
/home/src/regress/sys/kern/kqueue/kqueue-random.c
/home/src/regress/sys/kern/kqueue/kqueue-random.c:22:18: error: variable has
incomplete type 'struct timespec'
struct timespec ts;
^
/usr/include/sys/event.h:321:8: note: forward declaration of 'struct timespec'
struct timespec;
^
1 error generated.
*** Error 1 in /home/src/regress/sys/kern/kqueue (<sys.mk>:87 'kqueue-random.o')
robsd-regress-exec: process group exited 2
> sys/kern/setuid:
Exit: 1
Duration: 00:00:04
Log: 119-sys-kern-setuid.log
+ . /usr/local/libexec/robsd/util.sh
+ . /usr/local/libexec/robsd/util-ports.sh
+ . /usr/local/libexec/robsd/util-regress.sh
+ regress_root sys/kern/setuid
+ unpriv anton exec make -C /home/src/regress/sys/kern/setuid
==== run-regress-setuid_none ====
cc -O2 -pipe -Wall -Wformat -pedantic -MD -MP -o setuid_none
/home/src/regress/sys/kern/setuid/setuid_none.c
In file included from /home/src/regress/sys/kern/setuid/setuid_none.c:8:
/usr/include/sys/proc.h:373:21: error: field has incomplete type 'struct
sigaltstack'
struct sigaltstack p_sigstk; /* sp & on stack state variable */
^
/usr/include/sys/proc.h:373:9: note: forward declaration of 'struct sigaltstack'
struct sigaltstack p_sigstk; /* sp & on stack state variable */
^
/usr/include/sys/proc.h:385:15: error: field has incomplete type 'union sigval'
union sigval p_sigval; /* For core dump/debugger XXX */
^
/usr/include/sys/proc.h:385:8: note: forward declaration of 'union sigval'
union sigval p_sigval; /* For core dump/debugger XXX */
^
2 errors generated.
*** Error 1 in . (<sys.mk>:85 'setuid_none')
FAILED
