Hi Anton, Anton Lindqvist wrote on Fri, May 06, 2022 at 07:00:17AM +0200: > On Wed, May 04, 2022 at 10:58:43PM -0600, Theo de Raadt wrote:
>> These complaints about trivial regress failures, generally just >> output strings, are getting a bit tiring. >> You can fix it in about 1 minute, right? > I generally try to fix trivial things like this one but I don't always > have the time. If people find this more annoying than helpful I will > stop. Sorry i lost track what this one was originally about, but in general, i don't think it would be the best idea to stop reporting regression failures about "just output strings". I try to avoid breaking regress/ when committing, but sometimes things go wrong and i don't notice. In that case, i'm grateful for a heads-up, and it doesn't matter much whether or not a proposed fix is included. Maybe the situation in regress/usr.bin/mandoc/ is a bit special because it can be hard to judge for a non experts whether a seemingly trivial output change revealed by a test is intentional or a regression. Then again, even in other tools, seemingly trivial changes in output may be either intentional or undesirable... So if people are sure what the desired behaviour is and have the time, fixing it is certainly fine. If in doubt or short on time, alerting the developer who broke it, or if that is unknown, others who work in the area, is better than not doing so, i think. Yours, Ingo (Source-changes@ is not a typical discussion list - then again, i don't expect this conversation to continue for long, so i'm not switching lists.)
