CVSROOT: /cvs
Module name: src
Changes by: clau...@cvs.openbsd.org 2023/09/19 04:43:34
Modified files:
sys/kern : kern_pledge.c kern_sig.c
Log message:
Before coredump or in pledge_fail use SINGLE_UNWIND to stop all threads.
SINGLE_UNWIND unwinds to the kernel boundary. On the other hand
SINGLE_SUSPEND will sleep inside tsleep(9) and other sleep functions.
Since the code will exit1() very soon after it is better to already unwind.
Now one could argue that for coredumps all threads should stop asap to
get a clean dump. Using SINGLE_UNWIND the sleep will fail with ERESTART
and no copyout should happen in that case.
This is a bit of a workaround since SINGLE_SUSPEND has a small race
where single_thread_wait() returns before all threads are really stopped.
When SINGLE_EXIT is called quickly after this can blow up inside
sleep_finish.
Reported-by: syzbot+3ef066fcfaf991f2a...@syzkaller.appspotmail.com
OK mpi@ kettenis@
