CVSROOT: /cvs Module name: src Changes by: t...@cvs.openbsd.org 2024/10/31 09:26:05
Modified files: lib/libcrypto/ec: ec_asn1.c Log message: Clean up the mess in i2d_EC_PRIVATEKEY() Use a few local variables to make the checks at the start slightly less unappealing. Use those to simplify the conditionals a bit and avoid a particularly silly exit code. ok is set unless ret is 0, so what do you think 'return (ok ? ret : 0);' returns? By the way, ret < 0 is an error as well. While most of the stuff in this file could use a lot more cleanup, I think the first layer of cockroaches has been exterminated and there's even some faint golden glimmer between the turds. Let's shelve the biohazard warnings for now. ok jsing