On Wed, May 21, 2025 at 06:53:47AM +0000, Klemens Nanni wrote: > 21.05.2025 09:03, Jason McIntyre ??????????: > > this diff removes the quoting around "_ftp_proxy" (user) but does not > > mention it is doing so! > > > > what's the reason for the change? quoting something like that is pretty > > standard, and if you look down the page, at least -A uses this form for > > "ftp" and "anonymous". > > Preference, I guess. I'm fine with both. > > Manuals don't quote the root user, though, and tftpd(8) is the only manual > I found where an unprivileged user is mentioned... without quotes. >
well, first your commit message should say what you're changing. this is a lesson for me as well, since i'm guilty of glibly changing things with very terse commit messages! regarding the change: - we wouldn;t normally mark up "root" (or quote it) because root is a very general concept, we all understand it. specific users are very different, and either quoting or marking up the username makes the text easier to read. - tftpd(8) does not mark it up, but it does not mention other users. so at least it's internally consistent. your change made the page internally inconsistent. so i think we should reinstate it to how it was, and then we can have a conversation about if it's better to not quote usernames, or whether a specific mark up is required. (in my opinion it was good as it was) jmc
