On Wed, Apr 06, 2011 at 03:16:13PM -0600, Martynas Venckus wrote: > CVSROOT: /cvs > Module name: src > Changes by: marty...@cvs.openbsd.org 2011/04/06 15:16:13 > > Modified files: > sys/dev/acpi : acpivar.h acpivideo.c acpivout.c > > Log message: > Don't enumerate _DOD for attaching acpivout(4), since: > - ACPI spec. says _DOD is not required for brightness controls, > - The list returned by _DOD might be wrong, > - It's an unnecessary work to do. > Instead, decision to attach will be based on the actual methods > found, similarly like in the other ACPI drivers. > Tested by several on tech@. > OK kettenis@, marco@, pirofti@. > > pirofti@ asked me to note here that devices not supporting brightness > controls won't attach from now on. This shouldn't be a concern for > you, since such devices weren't doing anything at all, anyway.
You still do not understand what this was all about. Sad. Specially since you managed to make a useless note in the commit unlike I asked when I okayed this. The note should've said: Please note that this commit removes output switching code support from the driver as no machines were seen properly implementing the corresponding AML methods yet. Of course this goes to the mailinglist instead of the commit log. Should we start okaying commit messages from now on as well?!
