On 2013/01/01 07:19, Okan Demirmen wrote: > CVSROOT: /cvs > Module name: xenocara > Changes by: o...@cvs.openbsd.org 2013/01/01 07:19:56 > > Modified files: > app/cwm : calmwm.h client.c group.c kbfunc.c xutil.c > > Log message: > make num of groups no longer off-by-one; from Alexander Polakov > > note that a re-exec of cwm will not rewrite the group number atom of > *existing* clients, so they will remain off-by-one until each client has > its atom updated, or of course a restart of X. >
Does this actually fix something, or is it just cosmetic? It breaks my use of cwm. Trimmed config:- -- -- -- -- -- sticky yes bind XF86Back rcyclegroup bind XF86Forward cyclegroup # alt-<number> switch to virtual desktop bind M-1 grouponly1 bind M-2 grouponly2 bind M-3 grouponly3 bind M-4 grouponly4 bind M-5 grouponly5 bind M-6 grouponly6 bind M-7 grouponly7 bind M-8 grouponly8 bind M-9 grouponly9 # alt-shift-<number> move current window to virtual desktop bind MS-1 movetogroup1 bind MS-2 movetogroup2 bind MS-3 movetogroup3 bind MS-4 movetogroup4 bind MS-5 movetogroup5 bind MS-6 movetogroup6 bind MS-7 movetogroup7 bind MS-8 movetogroup8 bind MS-9 movetogroup9 -- -- -- -- -- Before this commit, when cwm started (and before carrying out any group operations), newly opened windows would be in group1 / _NET_WM_DESKTOP(CARDINAL) = 0, the initial root window is _NET_CURRENT_DESKTOP(CARDINAL) = 0, and when you do 'grouponly2' followed by 'grouponly1' those same windows are displayed. After this commit, we get the same atoms for root/client windows on the initial display, but 'grouponly2' followed by 'grouponly1' goes to _NET_CURRENT_DESKTOP(CARDINAL) = 1, and the only way to re-display the desktop0 windows is to use cyclegroup/rcyclegroup.
