CVSROOT: /cvs Module name: src Changes by: bl...@cvs.openbsd.org 2016/12/20 11:33:43
Modified files: sys/kern : uipc_domain.c sys/net : rtsock.c sys/netinet : ip_icmp.c ip_input.c tcp_usrreq.c sys/netinet6 : ip6_input.c nd6.c Log message: A NET_LOCK() was is missing in tcp_sysctl() which shows up as spl softnet assert failures. It is better to place the lock into net_sysctl() where all the protocol sysctls are called via pr_sysctl. As calling sysctl(2) is in the slow path, doing fine grained locking has no benefit. Many sysctl cases copy out a struct. Having a lock around that keeps the struct consistent. Put assertions in the protocol sysctls that need it. OK mpi@