On Fri, Aug 25, 2017 at 06:29:42AM -0600, Otto Moerbeek wrote:

> CVSROOT:      /cvs
> Module name:  src
> Changes by:   [email protected]    2017/08/25 06:29:42
> 
> Modified files:
>       usr.sbin/rbootd: Makefile 
> 
> Log message:
> -Wextra is over the top; note that int < sizeof(..) is generally safe, since
> the left hand side gets converted to size_t, making negative values very large
> so the test fails; ok kettenis deraadt@

A sloppy commit message.

I meant to say:

        if (int > sizeof(..)) {
                error handling
        }

will also enter the error handling for the case where the int is negative.
This is often what is intended, specifically the cadse that triggred
this commit (bpf.c:350).

        -Otto

Reply via email to