Probably. Thanks,
-- Raul On Sun, May 23, 2021 at 7:30 PM Ric Sherlock <tikk...@gmail.com> wrote: > > Thanks Raul, > That nailed it! > I made the suggested change at line 260 of jsource/sleef/src/common/misc.h > and libj.so now successfully compiles. > Should the repository be updated with this change? > > > On Mon, May 24, 2021 at 10:16 AM Raul Miller <rauldmil...@gmail.com> wrote: > > > It looks like you might have run into > > https://bugzilla.mozilla.org/show_bug.cgi?id=697810 (though I don't > > see any hint of that reported at > > https://gcc.gnu.org/bugzilla/buglist.cgi?quicksearch=NS_ALWAYS_INLINE#) > > > > Perhaps the simplest solution would be to find the -Werror line that > > is being used for that compilation instance and change it to > > -Wno-error or (based on the error message) adding > > -Wno-error=attributes to the gcc invocation that gets used for sleef > > on your system. (-Werror means: treat warnings as errors). > > > > That said, looking at sleef, it might be that if you changed line 260 from > > > > #define INLINE __attribute__((always_inline)) > > > > to > > > > #define INLINE __attribute__((always_inline)) inline > > > > that that would fix this problem for you (and also improve the speed > > of the result on your system). > > > > I hope this helps, > > > > -- > > Raul > > > > > > On Sun, May 23, 2021 at 5:08 PM Ric Sherlock <tikk...@gmail.com> wrote: > > > > > > I'm trying to compile J903beta from source on Ubuntu 18.04 but get a > > whole > > > bunch of the errors below, all of them to do with sleef. > > > Thinking it might be an issue with an compiler version, I tried on a > > Ubuntu > > > 20.04 machine but with the same result. > > > Any suggestions of how to resolve this? > > > > > > I'm using the make2 version of the build instructions. > > > I'm doing this to address the glibc version issue described in beta on > > the > > > 18.04 machine. > > > > > > ../../../../sleef/src/arch/helperavx2.h:84:19: error: always_inline > > > function might not be inlinable [-Werror=attributes] > > > 84 | static INLINE int cpuSupportsFMA() { > > > | ^~~~~~~~~~~~~~ > > > ../../../../sleef/src/arch/helperavx2.h:78:19: error: always_inline > > > function might not be inlinable [-Werror=attributes] > > > 78 | static INLINE int cpuSupportsAVX2() { > > > ---------------------------------------------------------------------- > > > For information about J forums see http://www.jsoftware.com/forums.htm > > ---------------------------------------------------------------------- > > For information about J forums see http://www.jsoftware.com/forums.htm > > > ---------------------------------------------------------------------- > For information about J forums see http://www.jsoftware.com/forums.htm ---------------------------------------------------------------------- For information about J forums see http://www.jsoftware.com/forums.htm
