Thanks very much for the review Doug. Made the following changes as per review Meta(info.upstream): http://modules.sourceforge.net/maillist.html Meta(info.maintainer): bruce.rothermal at sun.com Group: Configuration and Preferences
Passed syntax check Build Id 1135 http://jucr.opensolaris.org/review/packages/273/ Should I get additional reviews? Bruce Doug Leavitt wrote: > I reviewed and added comments to this package. > > The outstanding issues as I see it are: > I see the following issues that need to be addressed: > > Meta(info.upstream): > This item needs to have an actual contact point, email or web address > Perhaps: http://modules.sourceforge.net/maillist.html > Meta(info.maintainer): > This item needs to contain an email address of the maintainer (you) > This is an invalid group: > Group: Utilities/Shell > It must be one of the items from this list: > http://opensolaris.org/os/community/sw-porters/contributing/ipsclass/ > > > I plan to log a bug against jucr. It should validate some of these > better. > > Doug. > > Bruce Rothermal wrote: >> Could I please get a review. This is my 3rd request for a review of >> the modules package. >> >> The packages is http://jucr.opensolaris.org/review/packages/273/ >> >> This package has been built and tested to be working correctly. >> >> >> Bruce >> _______________________________________________ >> sw-porters-discuss mailing list >> sw-porters-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/sw-porters-discuss
