Amanda Waite wrote: > yuntong.jin wrote: >> Hi Amanda, >> Thanks for below comments on telepathy-glib in juicer >> >> ""Things that I'd like to see addressed before I would vote this in: >> >> add field Meta(info.classification) see >> http://opensolaris.org/os/community/sw-porters/contributing/ipsclass/ >> for classes. The format would be org.opensolaris.category.2008:/ >> >> 'Meta(info.repository_url)' should be the URL to the source code >> repository (svn, cvs, git, hg, etc). If there is no external access >> to the repository then leave this field out. >> >> permissions on all the header files should be 444 and permissions on >> the shared library should be 555 >> >> The README file (/usr/share/doc/telepathy-glib/README) mentions a >> spec/ directory but I don't see one. >> >> add an entry to the changelog in the spec file to say when you made >> the last change to the spec"" >> >> >> I have some questions about it: >> >> Should permissions on all the header files the shared library be >> 755? Those files are set 0755 in almost all specs . >> Files under spec/ is not installed in Makefile, should i include them >> in package? > It's a hangover from my SFW involvement where the recommendation is > (supposedly) that files installed in the top level /usr directories > shouldn't have the write bit set. To be honest I'll be happy if the > library is 755 and the headers are 644, currently even the header > files are 755 and that isn't right. As for the spec/ directory, I only > mention it because the README does, only you can say if it's needed or > not. > > Amanda I have updated according to your comments, pls review it . http://jucr.opensolaris.org/review/packages/641/
Latest successful build in here. http://jucr.opensolaris.org/build/viewjob/3537/ BR, -Simon >> >> http://jucr.opensolaris.org/review/packages/641/ >> >> BR, >> -Simon >> >> >> >> >> >> >> >
