Pascal Giard <evily...@gmail.com>: > On Wed, Jan 30, 2013 at 10:30 PM, Chris Bagwell <ch...@cnpbagwell.com> wrote: > > For SoX, you should be able to get an idea of API and ABI modifications > > using "git log -u src/sox.h" since that defines our interface to library. > > That shows no modifications in dot branch since 14.4.0 release. > Good!
This was part of the plan for dot. :-) However, reading section 8.6.2 of the Policy Manual, I wonder where the difference is between a library_do_operation() taking an enum and a sox_find_effect() or sox_effect_options() taking a string. Wouldn't that mean that it is considered an "ABI change" whenever an effect changes behaviour (e.g., due to a bug being fixed)? > > I'll have to read up on this new approach. Is it OK to ignore API/ABI > > changes related to internal-only symbols that we are allowing to leak out > > (those prefixed with lsx_)? > Hmm... are we suggesting users to make use of them in some cases? > Or we're discouraging that practice? The latter, I think. This is what sox.h says about it at the moment: > Symbols starting with "lsx_" or "LSX_" are internal use by libSoX > and plugins. LSX_ and lsx_ symbols should not be used by > libSoX-based applications. > In any case, why are we "leaking" them? I see there are lots of them, > they actually constitute the vast majority of symbols! (340/393). I'm not sure, but since the library is divided into many compilation units, we can't simply declare all of those functions static. That would mean a helper function from effects_i.c couldn't be used from within spectrogram.c anymore. So removing these symbols would have to happen at or after linking; I don't know how complicated or easy that is. Ulrich ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_jan _______________________________________________ SoX-devel mailing list SoX-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sox-devel
