Eric Wong <[email protected]> writes:
> Hi Pascal,
>
> I found a fix to this problem by adding lsx_error and lsx_flush
> to the regular expression (and I needed to "make clean" before
> rebuilding, so there's likely still a smaller build problem there).
>
> Pushed to the "ew/dyn-default-fix" branch on git://80x24.org/sox
> (as well as my "pu" (proposed updates) branch there)
>
> The size of regexp is difficult to maintain and perhaps we should
> use -export-symbols SYMFILE instead...
It's horrible as is, especially with all the nested alternatives. A
file with a symbol per line would be much cleaner.
> -------------------------8<-------------------------
> Subject: [PATCH] fix build with --with-dyn-default
>
> This was broken in commit 5c58413544fd600bf12fdc54fa9648f0bc1ea860
> ("Don't export (most) internal libsox symbols")
>
> and noticed by both Pascal Giard and myself:
> http://mid.gmane.org/CAJNNDmk0oU=haP3DmVMAG6mtNCg=cO=7roqx-eafo2lxkqt...@mail.gmail.com
> http://mid.gmane.org/[email protected]
> ---
> src/Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 7cceaaf..6d6acf5 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -95,7 +95,7 @@ libsox_la_LIBADD += @GOMP_LIBS@
>
> libsox_la_CFLAGS = @WARN_CFLAGS@
> libsox_la_LDFLAGS = @APP_LDFLAGS@ -version-info @SHLIB_VERSION@ \
> - -export-symbols-regex
> '^(sox_.*|lsx_(check_read_params|(close|open)_dllibrary|(debug(_more|_most)?|fail|report|warn)_impl|eof|fail_errno|filelength|find_(enum_(text|value)|file_extension)|getopt(_init)?|lpc10_(create_(de|en)coder_state|(de|en)code)|raw(read|write)|read(_b_buf|buf|chars)|realloc|rewind|seeki|sigfigs3p?|strcasecmp|tell|unreadb|write(b|_b_buf|buf|s)))$$'
> + -export-symbols-regex
> '^(sox_.*|lsx_(check_read_params|(close|open)_dllibrary|(debug(_more|_most)?|fail|report|warn)_impl|eof|error|fail_errno|filelength|find_(enum_(text|value)|file_extension)|flush|getopt(_init)?|lpc10_(create_(de|en)coder_state|(de|en)code)|raw(read|write)|read(_b_buf|buf|chars)|realloc|rewind|seeki|sigfigs3p?|strcasecmp|tell|unreadb|write(b|_b_buf|buf|s)))$$'
>
> if HAVE_WIN32_LTDL
> libsox_la_SOURCES += win32-ltdl.c win32-ltdl.h
> --
> EW
--
Måns Rullgård
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
SoX-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sox-devel
