Måns Rullgård <[email protected]> wrote:
> Eric Wong <[email protected]> writes:
>
> > From: Pander <[email protected]>
>
> Does "Pander" have a real name?
Does it matter for this project?
Fwiw, I'm against real name policies; and there's no
copyright assignment or DCO here.
I don't see an acceptable way to enforce such a thing.
Speaking for myself, I have too much social anxiety to attend
keysigning parties pre-COVID; and refuse to video conference
because of facial/voice recognition privacy issues. Proving
my real name isn't feasible.
<snip>
> > + if (stat->fft_average) {
> > + samples = (stat->fft_size / 2);
> > + ffa = effp->in_signal.rate / samples;
> > + re_average = lsx_malloc(sizeof(float) * (int)samples);
> > + }
> >
> > if (len) {
> > if (stat->read == 0) /* 1st sample */
> > @@ -146,10 +160,20 @@ static int sox_stat_flow(sox_effect_t * effp, const
> > sox_sample_t *ibuf, sox_samp
> >
> > if (stat->fft_offset >= stat->fft_size) {
> > stat->fft_offset = 0;
> > + if (stat->fft_average) {
> > + lsx_power_spectrum_f((int)samples, stat->re_in,
> > stat->re_out);
> > + for (i = 0; i < samples / 2; i++) /* FIXME: should be <=
> > samples / 2 */
>
> What's this about? If it should be <=, why isn't it?
>
> > + re_average[i] += stat->re_out[i];
>
> re_average is never initialised. This will produce garbage.
<snip>
> I'm skipping this patch unless someone can explain what the intent is.
> Then I might try to fix it.
I do agree this patch is buggy and I don't have the math knowledge
to comment on that part. But I should've caught the uninitialized
memory, at least :x
_______________________________________________
SoX-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sox-devel
