fbk-qr...@zacglen.net writes: > Further to my previous "silence" patch I have discovered > that there is another error involving the rms calculations. > > Initially, and after a reset, the rms sample window is empty > yet the rms calculation always uses the window size as > the calculation denominator. This will make the rms > value appear artificially low to start with. Instead, an > actual count of samples should be used. > > Incidentally, I think that the hard-coded 1/50 for selection > of a window size should also be parametized. Sometimes a size using > 1/20 (100 milliseconds when stereo) can be more appropriate than the > very small 40 millisecond hard-coded sample window size. > > The following is the updated patch:
I'm certainly not going to take a patch with several unrelated changes as is, nor am I going to do the work unravelling what's what. -- Måns Rullgård _______________________________________________ SoX-devel mailing list SoX-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sox-devel
