On 5/18/24 18:11, Martin Guy wrote:
OK, I've had a look at it on git master. I can't reproduce the "eat the CPU" effect but it segfaults when -x is greater than the number of samples... when the number of samples is less than 5000. -r4999 and -x5000 dumps core; -r5000 -x5001 works. Bizarre.On 5/18/24 17:19, Jan Stary wrote:There seems to be a bug in the spectrogram effect, also present in earlier releases. $ sox -c 1 -b 16 -r 1000 -n file.wav synth 1 sin 440 gain -3 $ sox file.wav -n spectrogram -x 1001 Segmentation fault (core dumped)The bug is sill there somewhere: instead of segfaulting, the following now makes SoX eat up the CPU, without producing a spectrogram: sox -c 1 -b 16 -r 1000 -n file.wav synth 1 sin 440 gain -3 sox file.wav -n spectrogram -x 1001I'll have a look at this in the next few days, caring about spectrograms as I do.
The actual defect is in spectrogram.c's "stop" routine, when it tries to place the "Time (s)" label at minus infinity
#0 0xb7e77c29 in print_at_ (pixels=0xa5e630 "", cols=144, x=-2147483614,y=24, c=1, text=0xbfe4b824 "Time (s)", orientation=0) at spectrogram.c:728
728 case 0: pixel(x + j, y - i) = c; break; (gdb) frame 1 #1 0xb7e78749 in stop (effp=0xa46410) at spectrogram.c:870870 print_at(left + (p->cols - font_X * strlen(text)) / 2, 24, Text, text);
This happens because strlen(txt) is unsigned, making the whole bracket expression unsigned and calculating 4294967248/2 instead of -48/2
The fix on git master is in src/spectrogram.c line 870, to prefix strlen(text) with (int)
I would post an issue and patch on sourceforge, but that seems useless as the existing patches haven't been applied since 2006.
But sox spectrogram is poor fare. Very slow, no log frequency axis and you can't change the FFT size. Even sndfile-spectrogram is better but if you want much much better spectrograms, use http://martinwguy.net/spettro
M
OpenPGP_signature.asc
Description: OpenPGP digital signature
_______________________________________________ SoX-devel mailing list SoX-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sox-devel
