Coe, Colin C. (Unix Engineer) wrote:
Hi all
<<0004-new-API-call-checkConfigDeployment.patch>>
<<0005-add-JUNIT-test-for-activationkey.-get-set-ConfigDepl.patch>>
Attached are two patches.
0004 implements a new API call checkConfigDeployment. This goes along
with getConfigDeployment and setConfigDeployment. It simply returns 1
if config files are to be deployed, 2 if not, and 0 (zero) on error.
0005 implements JUNIT tests for getConfigDeployment and
setConfigDeployment.
Comments, criticisms welcome.
CC
NOTICE: This email and any attachments are confidential.
They may contain legally privileged information or
copyright material. You must not read, copy, use or
disclose them without authorisation. If you are not an
intended recipient, please contact us at once by return
email and then delete both messages and all attachments.
------------------------------------------------------------------------
_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel
Hi Colin,
I have applied these patches to Spacewalk 0.3.
I did make a couple of minor modifications prior to applying the patch.
The modifications included things such as:
- minor change in return value (1=enabled, 0=disabled, exception on
error) - i chose to use exceptions to represent errors, since is more
consistent w/other apis
- minor changes to junit test to exercise the handler for
enable/disable/check
To see the final commit, refer to:
http://git.fedorahosted.org/git/?p=spacewalk.git;a=commit;h=28c757637e27bbb475b65e32779ab98dd650e5dd
If you have any questions or concerns, do let me know.
Thanks for the contribution !! :)
cheers,
Brad
_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel
