Hi Colin,
I have applied the various patches that you submitted to support the new
kickstart.profile.getCustomOption() and
kickstart.profile.setCustomOption() APIs. Thanks again for your
contribution ! :)
This included the following patches:
0001-Add-API-call-getCustomData-and-required-dependant-se.patch
0002-Include-the-API-call.patch
0003-Tidy-code-remove-commmented-code-and-fix-documentat.patch
0004-Silence-ant-checkstyle-messages.patch
0005-Add-setCustomOptions-API-call.patch
0006-Fix-missing-imports-and-other-thinkos.patch
For reference, the commit (which will be included in Spacewalk 0.3) can
be access via:
http://git.fedorahosted.org/git/?p=spacewalk.git;a=commit;h=b6396faa7612bfb790548df4b4add3e5c24747f1
I did make a few minor modifications prior to the submit. They
primarily involved the following:
1. moved system.profile.ServerProfileHandler.java to
kickstart.profile.ProfileHandler.java - this change was to place the new
APIs under the kickstart package
2. ProfileHandler.setCustomOptions - changed the 'options' input from a
String to a List<String> and made appropriate modifications to the
method to process as a list. The reason for this change is that each
option should be stored in the DB individually.
3. ProfileHandler.setCustomOptions - observed during testing that
options when added from the web-ui include a \r when stored in the DB.
In order to be consistent, updated the API implementation to also the
\r; otherwise, options added via the API would be viewed on a single
line via the web-ui. There were several possible solutions to this;
however, since we have a customer base that already has kickstart
profiles in their DB, I chose to avoid more complex solutions which
might involve migrating data in the DB (to strip existing \r) and allow
the UI to deal w/it during page rendering.
4. As you will see from the commit, I did apply the patches manually.
Unfortunately, due to some parallel development activities, one of the
classes (CryptoKeySerializer) was added to git before I was able to
apply the patch; therefore, it needed to be done manually. (My
apologies for the delay.)
There were likely a few other small tweaks, but the above are the key
items. If you have any questions or issues, please do let me know.
Please be aware, I did not add junit tests for these APIs, yet. Since
you mentioned that you were working on them, I did not want to duplicate
that effort; however, I did run several tests using python to validate
the behavior.
Again, appreciate your active participation in the project !
cheers,
Brad
Coe, Colin C. (Unix Engineer) wrote:
Hi Brad
Attached is a patch to fix CryptoKeySerializer.java. I got carried away with
cleaning up...
CC
________________________________________
From: Brad Buckingham [EMAIL PROTECTED]
Sent: Friday, 3 October 2008 8:39 PM
To: Coe, Colin C. (Unix Engineer)
Cc: [email protected]
Subject: Re: [Spacewalk-devel] Patches: serializers and setCustomOptions API
call
Coe, Colin C. (Unix Engineer) wrote:
Hi all
Attached are two patches:
0004 - fixes a bunch of checkstyle messages (apologies as I forgot to do this
before sending the last patch in)
0005 - adds setCustomOptions - thanks to jmrodri for pointing me in the right
direction with this.
Comments/criticisms welcome.
CC
NOTICE: This email and any attachments are confidential.
They may contain legally privileged information or
copyright material. You must not read, copy, use or
disclose them without authorisation. If you are not an
intended recipient, please contact us at once by return
email and then delete both messages and all attachments.
------------------------------------------------------------------------
_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel
Colin,
Thanks for submitting the patch. I plan to review/test today for
submission in to Spacewalk 0.3. Will let you know when it is completed.
cheers,
Brad
NOTICE: This email and any attachments are confidential.
They may contain legally privileged information or
copyright material. You must not read, copy, use or
disclose them without authorisation. If you are not an
intended recipient, please contact us at once by return
email and then delete both messages and all attachments.
_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel
