Hi
When I register a new xen machine it complains:

rhnreg_ks --serverUrl=http://server.gta/XMLRPC --activationkey=1-blah
--force
Error reading hardware information: dbus_bindings.DBusException
Error reading DMI information:

Being very new to the code base, I would like to check things first
before spending hours doing unnecessary work. I am a sysadmin and a
ex-delphi programmer wishing to become better at unix programming.

/usr/share/rhn/up2date_client/hardware.py:631

you will find     
# minimal DMI info
    try:
        ret = read_dmi()
        if ret:
            allhw.append(ret)
    except:
        print _("dmi error message"), sys.exc_type
# I changed the error message to confirm that this line is being called.

DMI does not exist on xen so would it make sense to in the exception
check whether it is xen and then return a specific error message or just
empty data which I think would be better...



If I should rather just submit a patch and then get an answer about
sensibility please take 2 secs to let me know.

Best Regards

______________________________________________________________________
This email has been scanned by the MessageLabs Email Security System.
For more information please visit http://www.messagelabs.com/email 
______________________________________________________________________

_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to