On Thu, Nov 20, 2008 at 12:25:36PM +0100, Miroslav Suchý wrote: > Jesus M. Rodriguez wrote: >>> Miroslav Suchý wrote: >>>> According the code the the returned version is content of web.version >>>> /etc/rhn/default/rhn_web.conf >>>> I see as best option to create new config option web.apiversion which we >>>> bump up independently on spacewalk version. And ideally return it back to >>>> 5.2 at least and act as API version 0.x never exist. >>>> Yes maybe we can bump it to 100 or 10 to clearly state that it has nothing >>>> to do with spacewalk versioning. >>>> >> I'm ok with this, seems like using the web_version has caused some problems >> with >> some scripts. > > OK. Done as: > https://bugzilla.redhat.com/show_bug.cgi?id=472346 > >> >> So to summarize what should happen, >> >> 1) add web.apiversion to /etc/rhn/default/rhn_web.conf >> 2) set the initial value to be 5.2 > I set it to 10.0
Why 10.0? Seems really arbitrary. If that was the intent, I can live with it. > >> At current it returns web.version + " Java" >> http://tinyurl.com/5c2egq > I removed the Java suffix as we do no need it now to distinguish between > api.get_system_version and api.get_version. If this can be problem raise > your voice. We added the Java suffix when we first released the api in Java, so that you could tell if the Satellite had the proper API installed after upgrade. It is no longer needed, and I'm glad you removed it. > >> 5) if you are relying on the value of api.get_system_version() please >> switch the appropriate api.get_version() method. > > Please now whenever you add new API call modify minor version > web.apiversion in web/conf/rhn_web.conf. And every Spacewalk release > bump up major version. > If you have better idea how to handle api versioning share the idea. How would this work under a normal development cycle? For example, in sw 0.4, if brad adds 4 new apis and I add 5 more, do we bump up the minor release by 9 i.e. 10.9? I don't see the need for bumping the minor release except maybe for a bug fix to an existing api which might change the behavior slightly, but aside from that I don't see any reason. Bumping the major release for every Spacewalk release makes perfect sense. -- jesus m. rodriguez | [EMAIL PROTECTED] sr. software engineer | irc: zeus rhn satellite & spacewalk | 919.754.4413 (w) rhce # 805008586930012 | 919.623.0080 (c) +-------------------------------------------+ | "Those who cannot learn from history | | are doomed to repeat it." | | -- George Santayana | +-------------------------------------------+ _______________________________________________ Spacewalk-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/spacewalk-devel
