On Tue, Dec 09, 2008 at 10:39:54AM +0100, Michael Mraka wrote: > Fedora Hosted Git Repositories - spacewalk.git/rss log, Jason Dobies <> wrote: > % Changed package architecture retrieval to not be a join > % > % • [DH] java/code/src/com/redhat/rhn/common/db/datasource/xml/ > % Package_queries.xml > % > % URL: http://git.fedoraproject.org/git/?p=spacewalk.git;a=commitdiff;h= > % 41585dce3e9b5ee5e2692f9eb73d221750456d9c > % > > Hi Jason, > just curious - what was the reason for this change? > > Both versions are sematicaly equivalent and use same execution plan :).
Doesn't some following commit get rid of that remaining INNER JOIN as well? In that case if would be a welcome cleanup. > --- > a/java/code/src/com/redhat/rhn/common/db/datasource/xml/Package_queries.xml > +++ > b/java/code/src/com/redhat/rhn/common/db/datasource/xml/Package_queries.xml > @@ -1075,11 +1075,12 @@ SELECT pn.name AS NAME, > AND p.evr_id = pe.id > GROUP BY p.name_id > ) full_list, > + rhnPackageArch pa, > rhnPackageName pn > INNER JOIN rhnPackage PKG ON pkg.name_id = pn.id > - INNER JOIN rhnPackageArch PA ON pa.id = pkg.package_arch_id > WHERE full_list.name_id = pn.id > AND full_list.name_id NOT IN (SELECT SP.name_id FROM rhnServerPackage SP > WHERE SP.server_id = :sid) > + AND pa.id = pkg.package_arch_id > ORDER BY UPPER(pn.name) > </query> > </mode> > > _______________________________________________ > Spacewalk-devel mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/spacewalk-devel -- Jan Pazdziora Satellite Engineering, Red Hat _______________________________________________ Spacewalk-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/spacewalk-devel
