-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Wed, 17 Dec 2008 17:38:08 +0100 Miroslav Suchý <[email protected]> wrote:
> Devan Goodwin wrote: > > This was on my TODO but hasn't been done yet, I'll try to get it in > > there today. > > Is is just me or .... > I had the impression that you start working on build.py so that it > will be easier to read/maintain. Yes this is one of the reasons, and because I believe it was a better fit for the task at hand. (particularly in reference to the functionality to be added for building satellite pkgs) > > But if I compare: > $ wc -l Makefile.* > 85 Makefile.git > 189 Makefile.srpm > 113 Makefile.tag-release > 387 total > > $ wc -l bin/build.py lib/spacewalk/__init__.py lib/spacewalk/releng/* > 26 bin/build.py > 0 lib/spacewalk/__init__.py > 383 lib/spacewalk/releng/builder.py > 155 lib/spacewalk/releng/cli.py > 178 lib/spacewalk/releng/common.py > 19 lib/spacewalk/releng/__init__.py > 251 lib/spacewalk/releng/tagger.py > 1012 total Ease of maintenance and readability do not correlate to a low line count. For starters the python scripts are heavily commented, try to stick to 80 characters per line, and in general do not jam complicated multi-step procedures into single (or few) lines. At no point was it stated that build.py would result in less lines. > > And I do not see build.py much readable then Makefile > I know you have a stronger shell background than myself and thus may not find it much different. I however find it substantially more readable and and easy to work with for the tasks I have to complete, I'm hopeful future developers who work on it will as well, and thus I chose to move forward with it. If on the other you're stating you actually find it *less* readable, then please feel free to point out where and I will try to remedy the problem. > And build.py still do not have the functionality of Makefile. > Tack on another 50 lines to complete the small pieces of missing functionality if it makes you feel better. :) Honestly the remaining pieces will not require much additional work or lines of code. Devan - -- Devan Goodwin <[email protected]> Software Engineer - Spacewalk / RHN Satellite Halifax, Canada 650.567.9039x79267 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEARECAAYFAklJOmcACgkQAyHWaPV9my5Q/QCffLC4aibu/wNl2x2JopljCO0c mOoAoLio68ifW1a7xCTyUyQCg1oCBcQf =KOFI -----END PGP SIGNATURE----- _______________________________________________ Spacewalk-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/spacewalk-devel
