On Fri, 2009-02-06 at 22:21 -0500, Jesus M. Rodriguez wrote:
> Why is ACTIONS final if we're actually changing it?

Final just means we're not going to assign ACTIONS a new map. If we
wanted to make the contents of the map itself final, we'd use
Collections.unmodifiableMap.

It's final because it's usually a bad idea to synchronize on non-final
objects. Not that we were changing it, but I was in there and feeling
especially OCD.

> Also please keep a comment above handleTransaction() so folks know that it is
> REQUIRED.

Will do.

> jesus
> 
> http://git.fedorahosted.org/git/?p=spacewalk.git;a=commitdiff;h=37ba4c749fcfda3a9cfd1facaf0a10a17adeffe6
> 
> _______________________________________________
> Spacewalk-devel mailing list
> [email protected]
> https://www.redhat.com/mailman/listinfo/spacewalk-devel
-- 
Jason Dobies ([email protected])
RHN Satellite & Spacewalk
RHCE# 805008743336126
Freenode: jdob @ #spacewalk, #spacewalk-devel

_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to