Re: [Spacewalk-devel] 487563 - switching take_snapshots to enable_snapshots

Thu, 05 Mar 2009 06:01:16 -0800

This is a good question. I'll be working on modifications in the future to make the documentation links configurable. This would be to address the fact that the various help links in Spacewalk are currently dead-links. When I do that, it'll likely be controlled based on properties defined rhn_docs.conf. If I follow by adding constants to Config.java, it'll likely lead to adding 200+ additional constants (basically representing all of the various links we currently have in the UI for help)... For this case, I'd prefer not to duplicate the rhn_docs.conf properties in Config.java, but I will if it is preferred by the majority. 

jmrodri wrote:
Do we 'really' need constants for EVERY configuration entry? I know it makes a bit easier to use auto-completion in the IDE, but it seems a bit redundant to modify a Config reader class every time. And personally I really dislike the indirection, I always end 
up with 2 greps one for the config entry, then one for the constant.

Am I the only one this annoys?

jesus



      Sent to you by jmrodri via Google Reader:



    487563 - switching take_snapshots to enable_snapshots
    
<http://git.fedoraproject.org/git/?p=spacewalk.git;a=commitdiff;h=e21a89a899233c95628c825e25eea6b3efacaab0>
via Fedora Hosted Git Repositories - spacewalk.git/rss log <http://git.fedoraproject.org/git/?p=spacewalk.git;a=summary> by Justin Sherrill <[email protected]> on 3/4/09 

487563 - switching take_snapshots to enable_snapshots

    * [D
      
<http://git.fedoraproject.org/git/?p=spacewalk.git;a=blobdiff;f=backend/rhn-conf/rhn.conf;fp=backend/rhn-conf/rhn.conf;h=b70d86667902036abcf2f1e942d39994f4d9596f;hp=0bb2e74be2ae306835e7eb65a26d26c53d82b631;hb=e21a89a899233c95628c825e25eea6b3efacaab0;hpb=66e2235ca17df598dfbce505179ab12905745e37>H
      
<http://git.fedoraproject.org/git/?p=spacewalk.git;a=history;f=backend/rhn-conf/rhn.conf;h=e21a89a899233c95628c825e25eea6b3efacaab0>]
      backend/rhn-conf/rhn.conf
    * [D
      
<http://git.fedoraproject.org/git/?p=spacewalk.git;a=blobdiff;f=backend/server/rhnServer/server_lib.py;fp=backend/server/rhnServer/server_lib.py;h=7fc4c2409dc3217be21fae36c366ae1f6e9435d4;hp=7de3daa07a0a0fe2631d575f0a477d68e5c6a376;hb=e21a89a899233c95628c825e25eea6b3efacaab0;hpb=66e2235ca17df598dfbce505179ab12905745e37>H
      
<http://git.fedoraproject.org/git/?p=spacewalk.git;a=history;f=backend/server/rhnServer/server_lib.py;h=e21a89a899233c95628c825e25eea6b3efacaab0>]
      backend/server/rhnServer/server_lib.py
    * [D
      
<http://git.fedoraproject.org/git/?p=spacewalk.git;a=blobdiff;f=java/code/src/com/redhat/rhn/common/conf/Config.java;fp=java/code/src/com/redhat/rhn/common/conf/Config.java;h=958b7eab6a33d1476965ba001d7c18b1dfb112f1;hp=aac914467cea3b0c3b98e0102a73140aecc9c2e5;hb=e21a89a899233c95628c825e25eea6b3efacaab0;hpb=66e2235ca17df598dfbce505179ab12905745e37>H
      
<http://git.fedoraproject.org/git/?p=spacewalk.git;a=history;f=java/code/src/com/redhat/rhn/common/conf/Config.java;h=e21a89a899233c95628c825e25eea6b3efacaab0>]
      java/code/src/com/redhat/rhn/common/conf/Config.java
    * [D
      
<http://git.fedoraproject.org/git/?p=spacewalk.git;a=blobdiff;f=web/modules/rhn/RHN/DB/Server.pm;fp=web/modules/rhn/RHN/DB/Server.pm;h=03b6dc7d3259a418d7cf84ba582d33175216ed0e;hp=81ae3413b9995f8024f0c08f68ba54043181be5d;hb=e21a89a899233c95628c825e25eea6b3efacaab0;hpb=66e2235ca17df598dfbce505179ab12905745e37>H
      
<http://git.fedoraproject.org/git/?p=spacewalk.git;a=history;f=web/modules/rhn/RHN/DB/Server.pm;h=e21a89a899233c95628c825e25eea6b3efacaab0>]
      web/modules/rhn/RHN/DB/Server.pm




      Things you can do from here:

    * Subscribe to Fedora Hosted Git Repositories - spacewalk.git/rss
      log
      
<http://www.google.com/reader/view/feed%2Fhttp%3A%2F%2Fgit.fedoraproject.org%2Fgit%2F%3Fp%3Dspacewalk.git%3Ba%3Drss?source=email>
      using *Google Reader*
    * Get started using Google Reader
      <http://www.google.com/reader/?source=email> to easily keep up
      with *all your favorite sites*
------------------------------------------------------------------------ 

_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel


_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to