Mike McCune wrote:
I just pushed a big port of our old perl based kickstart file downloader
into java:
http://git.fedorahosted.org/git/spacewalk.git?p=spacewalk.git;a=commit;h=a183f6001d9dcedf1650fcb58098d517be3413b2
If anyone notices anything odd or busted about kickstarts, let me know
Mike
Since I'm on a comment on commits rampage, here are some comments :)
FileUtils
-----------
* Would it be better to have a single try/catch around the code
with the 2 exceptions in the catch?
try {
// all the code in here
} catch (FileNotFoundException fnfe) {
} catch (IOException ioe) {
}
* you really don't want to do the is.close() after the while,
you want a finally clause where you check it for null and make sure
to close it there. If for some reason you get an IOexception while
reading you will leave the InputStream open.
MD5Sum
-------
* why didn't you use MD5Crypt class in common.util? or add to it instead
of creating MD5Sum
DownloadAction
----------------
* We do a split on the StringUtils, do we know that there is at least
2 items in the array to be confident that String treeLabel = split[2]
will not cause a NullPointer or ArrayIndexException?
What's interesting is that this probably all could've been a servlet
instead of page action, but tihs already existed so I can understand
not changing it.
--
jesus m. rodriguez | [email protected]
sr. software engineer | irc: zeus
rhn satellite & spacewalk | 919.754.4413 (w)
rhce # 805008586930012 | 919.623.0080 (c)
+-------------------------------------------+
| "Those who cannot learn from history |
| are doomed to repeat it." |
| -- George Santayana |
+-------------------------------------------+
_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel
