On Fri, Mar 20, 2009 at 4:25 PM, Jason Dobies <[email protected]> wrote:
> http://git.fedorahosted.org/git/?p=spacewalk.git;a=commitdiff;h=ffa3f5367efc9d5ea5a884ae844d920c66efe6a4
>
> (trying to get myself in the habit of looking over git commits, though this
> is an admittedly stylistic question with no real substance to it)
>
> Just curious, but why are the following variables in caps? It's a minor
> thing, was just curious if they were at one point static or something.
>
> +    private long ERROR_COUNT;
> +    private long DISTRO_WARN_COUNT;
>
>

Yeah that's wrong :) only thing that should be caps like that are static final.
Those shouldn't be all caps.  Good catch Jay.

jesus

_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to