On Wed, Mar 25, 2009 at 9:48 AM, Jeff Ortel <[email protected]> wrote: > The following schema files are flagged to be EXCLUDED from the installed > schema. > > <snip> > 31 # check if we need to include a SQL file > 32 check-sql-file = $(shell egrep -i \ > 33 '^--[[:space:]]*EXCLUDE:[[:space:]]*(all|$(SCHEMA))' \ > 34 $(file) >/dev/null 2>&1 || echo $(file)) > </snip> > > The Makefile.schema ^^ seems to check for this comment and when found, > excludes the file from the universal .sql file. Is this correct? If so, > any reason we don't just remove them from the repo? Many of them will not > load because then reference an non-existent packages rhn_email and rhn_ep > anyway. > > > FILES: >
Yeah if we're excluding them why have them at all :) > packages/rhn_qos.grants.sql:-- EXCLUDE: all > packages/rhn_qos.pkb:-- EXCLUDE: all > packages/rhn_qos.pks:-- EXCLUDE: all I don't see any code using rhn_qos, so safe to delete > procs/create_first_org.sql:-- EXCLUDE: production this looks used by satCerts.py so looks like it's needed. > procs/entitle_order.sql:-- EXCLUDE: all not used in spacewalk > procs/adler32.sql:-- EXCLUDE: all doesn't look like it's used by anything > synonyms/rhnUser.satellite.sql:-- EXCLUDE: production DEAD, remove it, failed attempt of refactoring web_contact into rhnUser > synonyms/web_customer_id_seq.sql:-- EXCLUDE: all > synonyms/web_customer.sql:-- EXCLUDE: all > synonyms/web_customer.sql:-- EXCLUDE: all These 3 are synonyms which I don't think we use > tables/rhnServerGroupMembers_email_triggers.sql:-- EXCLUDE: all not sure, I don't think we use this one either. Someone want to confirm? > tables/rhnServerInfo-rescue.sql:-- EXCLUDE: all seems useless,remove > tables/rhnSatelliteCert.sql:-- EXCLUDE: production weird, we use this table why is it excluded? > tables/rhnUserGroupMembers_email_triggers.sql:-- EXCLUDE: all dead > tables/rhnUserServerGroupPerms_triggers.sql:-- EXCLUDE: all I don't think we do this anymore. > tables/rhnInfoPane_synonyms.sql:-- EXCLUDE: Satelitte useless synonym, remove > tables/rhnFAQ_satdata.sql:-- EXCLUDE: production this data is so out of date, it's not even worth having. Which reminds me we need to also rmeove the Feedback code from perl. > tables/rhnUserInfo_data.sql:-- EXCLUDE: all not sure what this is doing., seems useless > tables/valid_countries.sql:-- EXCLUDE: production this data is currently being used, why it's excluded is odd > views/rhnUserAvailableChannels_grants.sql:-- EXCLUDE: all this grants select to rhn_dml_r, I don't know what rhn_dml_r is. If it's not being used let's just remove it. > views/rhnAutoScheduleActionView.sql:-- EXCLUDE: all not used, remove jesus _______________________________________________ Spacewalk-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/spacewalk-devel
