On Fri, Apr 24, 2009 at 12:05 PM, Devan Goodwin <[email protected]> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Fri, 24 Apr 2009 11:49:50 -0400
> Jason Dobies <[email protected]> wrote:
>
>> My understanding is that the $revision$ (or $Rev$ or $Revision$ ...
>> I've seen it a number of different ways) would be substituted on
>> commit, but looking through the git site it's not. I ask because
>> checkstyle enforces that we have an @version tag, but it's not really
>> doing anything if these subs don't work.
>>
>> Does git actually support this? I can't find anything that says they
>> do or what the format is. And if it does, I'm not sure what they'd
>> actually substitute since the sha would be kinda brutal to look at in
>> the java file.
>>
>> If it doesn't, any objects to me taking out the rule that requires
>> the @version tag in the class header?
>>
>>
>
> +1 to dropping it altogether. I have no use for revisions in source
> files at least.
>

+1 time for a nice little perl -i -pe script and an update to the checkstyle
rules. :)

jesus

_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to