On Thu, May 07, 2009 at 03:21:45PM +0200, Jan Pazdziora wrote: > On Thu, May 07, 2009 at 09:07:13AM -0400, Jason Dobies wrote: > >> Before we open up this can of worms again look at this bug: > >> > >> https://bugzilla.redhat.com/show_bug.cgi?id=459827 (sorry private bug) > >> > >> jesus > > > > "Increasing the length of the column probably isn't the right solution. " > > > > Is there more to it than that (referring to the can of worms comment, > > I'm guessing there was a non-documented debate)? I'm not seeing a real > > reason why increasing the name to match the label size is a bad idea. > > This has come up twice in BZs now and I just saw it on the satellite > > mailing list as well. > > Isn't the main problem here the fact that whatever limit you chose, if > the original channel is at or near the limit, the cloned one will be > over limit? So the real fix is to
PRECISELY :) > > - match the textfield length in the WebUI to the column width, > whatever that one is; already done, the problem is we autogenerate the string and generate the HTML with that value. If you tried to type more into the field the browser does the right thing and won't let you. But it WILL accept the string we said should go in there from the rendering side. I put in code to capture this case, and show an error indicating that it has to be no more than 64 (size of column now) and list of valid characters. > - if the generated name would end up longer, truncate it in such a way > that the name is still unique; That was an option, but required to do a query to figure out how to make it unique without resorting to a random(). > - when handling the form, verify that the data is indeed shorter or > equal the column width. It does do that :) -- jesus m. rodriguez | [email protected] sr. software engineer | irc: zeus rhn satellite & spacewalk | 919.754.4413 (w) rhce # 805008586930012 | 919.623.0080 (c) +-------------------------------------------+ | "Those who cannot learn from history | | are doomed to repeat it." | | -- George Santayana | +-------------------------------------------+ _______________________________________________ Spacewalk-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/spacewalk-devel
