Uh ? I am confused

    public static final String  _MEM = "kickstart.virt_mem_size_mb";

return getInt(VIRT_MEM, 512) is just using that

Dunno how its any different from what you suggested..
I am I missing anything here ?

Partha
Jesus M. Rodriguez wrote:
Partha,

This should probably be

public int getDefaultVirtMemorySize() {
   return Config.get().getInt("virt.default.memsize", 512);
}

That way we can override the value via config at any time.

jesus

On Wed, Jun 24, 2009 at 12:34 PM, Partha Aji<[email protected]> wrote:
 java/code/src/com/redhat/rhn/common/conf/Config.java |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 72a7c0fd5148ccc994065f9b9ad9d7408bb5223b
Author: Partha Aji <[email protected]>
Date:   Wed Jun 24 12:36:31 2009 -0400

   507888 - Set the default virt mem value to 512 instead of 256

   Apparently thats the minimum requirement.

diff --git a/java/code/src/com/redhat/rhn/common/conf/Config.java 
b/java/code/src/com/redhat/rhn/common/conf/Config.java
index 13fe9c3..ad40462 100644
--- a/java/code/src/com/redhat/rhn/common/conf/Config.java
+++ b/java/code/src/com/redhat/rhn/common/conf/Config.java
@@ -807,7 +807,7 @@ public class Config {
     * @return the memory size
     */
    public int getDefaultVirtMemorySize() {
-        return getInt(VIRT_MEM, 256);
+        return getInt(VIRT_MEM, 512);
    }

    /**


_______________________________________________
spacewalk-commits mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/spacewalk-commits


_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel


_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to