Moving this topic to spacewalk-devel as it is better suited to be here.
Jeff proposed a few changes to java checkstyle rules. Below is a list
of the proposed changes:
1) remove rule that requires .java files to end with a NL.
2) Increase line length to 120.
3) Stop mandating style on wrapping operators.
4) Update the HiddenField rule to ignore parameters that hide fields.
A summary of most of the responses is as follows:
1) NL required because it makes git and other scm diffs easier. Most
folks are AGAINST removing this.
Proposal: keep this rule as it is today, require NL.
2) Increase line length to 120.
Indifference to the rule was counted as a vote FOR.
Votes for: ** (1 indifferent)
Votes against: ******
Proposal: keep the rule as it is today at 92 characters.
3) Stop mandating style on wrapping operators.
Indifference to the rule was counted as a vote FOR.
Votes for: ******** (3 indifferent)
Votes against:
Proposal: change the rule to IGNORE wrapping operators.
4) Update the HiddenField rule to ignore parameters that hide fields.
Indifference to the rule was counted as a vote FOR.
Votes for: ******** (4 indifferent)
Votes against:
Proposal: it seems to be even 4 for and 4 indifferent, but since
indifferent = FOR, change the rule to IGNORE hiddenfields.
Summary
--------
Out of the 4 proposals, it seems that 3 & 4 will change. I will leave
this proposal out here until Friday to let folks think it over again.
If you want to change or add your vote, reply to the list. If the
votes do not change the decisions by Friday, I will change the rules
then.
--
jesus m. rodriguez | [email protected]
sr. software engineer | irc: zeus
rhn satellite & spacewalk | 919.754.4413 (w)
rhce # 805008586930012 | 919.623.0080 (c)
+-------------------------------------------+
| "Those who cannot learn from history |
| are doomed to repeat it." |
| -- George Santayana |
+-------------------------------------------+
_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel
