Got a chance to review your commit. Comments inline,
On 08/04/2009 03:53 PM, Joshua Roys wrote:
Hello all,
Attached is a patch that lets you play around with symlinks through
the config management interface (rhbz#428190). It's a bit of a hack
in the sense that it asks you to put the target of the symlink in the
file contents. Also, a few things are unfinished or don't do what is
expected with this patch.
Things to do/fix:
- asking for a diff dereferences the symlink. move the code from
transaction.py to file_utils.py/process?
I would prefer the _do_symlink logic to sit in file_utils.py personally.
I think it fits better there.
- integrate with deploy/rollback. pretend symlinks are files in
transaction.py? necessary with symlinks?
I'm fine with that.
- hide the owner:group/mode fields? always root:root/0777?
hrm instead of hiding I would grey em out so user cant edit that field
and tells em its not relevant.
- when you click on "Symbolic link" in the web interface, hide the
"File Contents" box and have a "Destination" input field appear?
again I would lean toward jus grey em out so user cant edit.
- on the Channel overview page, the incorrect count of files appears.
where is this number calculated from? (how does it get into
ConfigChannelDto.java?)
Looks like this happens through ConfigurationManager.java. If you see
the getFileCounts method, it eventually calls doCountFiles method which
should call the data source query (files_in_channel in
config_queries.xml. So you mgiht want to poke at queries in that file.
~ Prad
Anyone have some advice on the last one? Or any suggestions on the
other ones, too.
Thanks,
Joshua Roys
------------------------------------------------------------------------
_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel
--
--
Pradeep Kilambi
Senior Software Engineer
RHN Satellite Engineering
Phone: +1 919 754 4285
RHCE # 805008680430554
_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel
