Hrm I haven't been paying attention to this, but you should never just close FileWriters, etc. The better approach is to use a try/catch to close it. We should never really be throwing IOExceptions when we can handle them, also logging a warning after catching an IOException is not the best idea either.
jesus On Thu, Oct 8, 2009 at 3:36 PM, Joshua Roys <[email protected]> wrote: > On 09/21/2009 02:31 PM, Joshua Roys wrote: >> >> Hello all, >> >> Attached is a patch to correctly display the number of files, dirs, and >> symlinks successfully compared to and differing from Spacewalk. >> >> The second patch makes the diff output sent to Spacewalk (from config >> files with differences) appear in a fixed-width font in the webUI. >> >> Also attached is a patch that we're currently using locally to allow us >> to have channels that start with "Red Hat" etc. >> >> Thanks, >> >> Joshua Roys > > Hello again, > > Attached is a patch to plug a fd leak. I relied a little too much on java > to clean up after me - and here's a situation it doesn't. > > Thanks, > > Joshua Roys > > _______________________________________________ > Spacewalk-devel mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/spacewalk-devel > _______________________________________________ Spacewalk-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/spacewalk-devel
