> commit f987184526fb2cecf47b9dce8bf69c1c66a86d88
> Author: Joshua Roys <joshua.r...@gtri.gatech.edu>
> Date:   Thu Mar 18 14:00:07 2010 +0000
> 
>     Fix a memory leak in rhnsd
> 
> diff --git a/client/rhel/rhnsd/rhnsd.c b/client/rhel/rhnsd/rhnsd.c
> index 357c59d..1e8fe21 100644
> --- a/client/rhel/rhnsd/rhnsd.c
> +++ b/client/rhel/rhnsd/rhnsd.c
> @@ -604,6 +604,7 @@ static int parse_systemid_path(char* systemid_path, int 
> systemid_path_length)
>          }
>          fclose(config_file);
>      }
> +    regfree(&re_systemIdPath);
>      return ret;
>  }

Joshua,

thanks for catching this.

I wonder if you also want to add a check for the return value of that
regcomp call.

Yours,

-- 
Jan Pazdziora
Principal Software Engineer, Satellite Engineering, Red Hat

_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to