Hey Colin, thank you for your patch. I've applied it as: http://git.fedorahosted.org/git/spacewalk.git/?p=spacewalk.git;a=commitdiff;h=7bf72668b4fac1a02aff73fc05e437d0bb5116ec
I just updated apidoc and removed the channelAdminPermCheck() call. (A regular user with no special rights is able to list child channels on webui, so he shouldn't need any extra permissions to do the same operation using API.) Regards, Tomas -- Tomas Lestach RHN Satellite Engineering, Red Hat ----- "Colin Coe" <[email protected]> wrote: > Hi Tomas > > Thank you for your comments. I have re-implemented this API call > using ChannelFactory.getAccessibleChildChannels. > > CC > > On Fri, Mar 26, 2010 at 10:39 PM, Tomas Lestach <[email protected]> > wrote: > > Hey Colin, > > > > channel.software.listChildren could be useful. > > > > I check your patch and here are my comments: > > > > We already have methods to list child channels. So there's no need > to implement new ways. > > Just check > java/code/src/com/redhat/rhn/domain/channel/ChannelFactory.java for > > > > * listAllChildrenForChannel(Channel parent) { > > * getAccessibleChildChannels(Channel baseChannel, User user) > > > > Because the api calls are based on the authenticated user, I'd use > the 2nd option to list only the accessible channels to the > authenticated user. > > > > Regards, > > Tomas > > > > -- > > Tomas Lestach > > RHN Satellite Engineering, Red Hat > > > > ----- "Colin Coe" <[email protected]> wrote: > > > >> Hi all > >> > >> Attached is a patch to implement this API call. > >> > >> Comments/criticisms welcome. > >> > >> CC > >> > >> -- > >> RHCE#805007969328369 > >> > >> _______________________________________________ > >> Spacewalk-devel mailing list > >> [email protected] > >> https://www.redhat.com/mailman/listinfo/spacewalk-devel > > > > _______________________________________________ > > Spacewalk-devel mailing list > > [email protected] > > https://www.redhat.com/mailman/listinfo/spacewalk-devel > > > > > > -- > RHCE#805007969328369 > > _______________________________________________ > Spacewalk-devel mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/spacewalk-devel _______________________________________________ Spacewalk-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/spacewalk-devel
