Hi Justin

Is this a bit better?  http://fpaste.org/LJwb/

Thanks

CC



On Thu, Apr 8, 2010 at 5:49 AM, Colin Coe <[email protected]> wrote:
> Hi Justin
>
> Thanks for the feedback.  I'll have another look at this and re-submit.
>
> CC
>
> On Thu, Apr 8, 2010 at 1:21 AM, Justin Sherrill <[email protected]> wrote:
>> On 4/6/10 9:55 AM, Colin Coe wrote:
>>> Hi all
>>>
>>> As per the API Addition page, I've added 'arch' to the
>>> channel.list*Channels API calls.
>>>
>>> Comments/criticisms welcome
>>>
>>> CC
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> Spacewalk-devel mailing list
>>> [email protected]
>>> https://www.redhat.com/mailman/listinfo/spacewalk-devel
>> Hey Colin,
>>
>> Having it do the lookups of package Arch in the Serializer really isn't
>> the right way to do it as Serializers are just meant to translate the
>> existing data.
>>
>> I would either add joins to rhnChannelArch to get the label in each of
>> the queries or write a elaborator that just gets the channel arch and
>> make each of those queries use the elaborator.
>>
>> Thanks,
>>
>> -Justin
>>
>>
>> --
>> Justin Sherrill, RHCA          1801 Varsity Drive.
>> Software Engineer                Raleigh, NC 27603
>> Red Hat, Inc.
>>
>> _______________________________________________
>> Spacewalk-devel mailing list
>> [email protected]
>> https://www.redhat.com/mailman/listinfo/spacewalk-devel
>>
>



-- 
RHCE#805007969328369

_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to