On Mon, 19 Apr 2010 13:20:02 +0200, Miroslav Suchý <[email protected]> wrote:

On 04/10/2010 09:27 PM, Lukas Durfina wrote:
So, here is the patch for the backend code.

I have several comments:

backend/server/importlib/debPackage.py:
Why is tagMap and _already_mapped attributes of class? Why not use attributes of instance and use regular constructor? Then we will not need createPackage function.


Just curious question:
 What is wrong with that way? I have used it, because all other packages
classes (rpmPackage, rpmBinaryPackage, mpmBinaryPackage) are implemented in that style.

_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to