On Thu, Apr 29, 2010 at 05:08:31PM +0000, Joshua Roys wrote:
> client/tools/rhncfg/config_common/transactions.py | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> New commits:
> commit cae64f15933666eca92edaa3dad2d00f22954113
> Author: Joshua Roys
> Date: Thu Apr 29 17:04:21 2010 +0000
>
> 587285 - provide a useful error message when lsetfilecon fails
Joshua,
thank you for the fix!
When you commit and push a fix for an existing bugzilla, besides
putting the bugzilla number to the commit message (which you did,
thanks!), could you please make a note in that bugzilla with something
like
Fixed in Spacewalk master cae64f15933666eca92edaa3dad2d00f22954113.
and move the bugzilla to MODIFIED, while reassigning it to yourself?
Sandro,
I've now reopened the bugzilla 587285 and set the state to MODIFIED.
We prefer to only CLOSE the bugzilla when we have the package built
and either in the nightly repo, or in Spacewalk release.
Ideally, the workflow should be
NEW
-> ASSIGNED (developer has looked at the bugzilla)
-> MODIFIED (with comment pointing to a specific commit SHA1)
-> ON_DEV (package was tagged and built, ideally with comment
having the name-version-release information)
-> ON_QA (package is in repo)
-> VERIFIED (the original reporter or Satellite QA verified
the fix with the new package)
-> CLOSED (CURRENTRELEASE or RAWHIDE)
I've now put note to this effect to
https://fedorahosted.org/spacewalk/wiki/BugHandling.
Thank you,
--
Jan Pazdziora
Principal Software Engineer, Satellite Engineering, Red Hat
_______________________________________________
Spacewalk-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/spacewalk-devel