Hello,
On 02/28/2011 05:08 AM, Miroslav Suchy wrote:
Dne 28.2.2011 07:12, Marcelo Moreira de Mello napsal(a):
Hello,
Added as attachment the patch for BZ#496823 which includes the a man
page for /etc/rhn/rhn.conf file.
The patches are little malformed. The first line should not be there
as I'm getting:
$ git am
/tmp/0001-Adding-usr-share-man-man5-rhn.conf.5-manpage-file.patch
Patch format detection failed.
I removed the first line, and then it applied cleanly.
0001-Adding-usr-share-man-man5-rhn.conf.5-manpage-file.patch
Nice.
I have several other suggestion. E.g. to document options:
pam_auth_service
enable_nvrea
web.is_monitoring_backend
web.is_monitoring_scout
and mention that there is dozens other options in /etc/rhn/default/*.conf
which you can override. With big warning, that you have to known what
are you doing.
But there is always place to improvements :)
So commiting now. If you want to improve it more, send another patch.
Sure! I will improve the man page and then send new patchs. Thx for
suggestions!
0002-Modifing-SPEC-file-including-new-man-page.patch
I did not applied this one.
1) do not put changelog entried in patch. Changelog entries are
automatically generated when someone call 'tito tag'. And it does more
thing then just generating changelog entries.
2) There is no need to gzip man page. RPM will do that automatically.
So this diff is sufficient:
+%doc %{_prefix}/share/man/man5/rhn.conf.5*
I commited this one line on my own.
Ehm and when I'm writing this email I realized that you should use
%{_mandir} instead of %{_prefix}/share/man. But this is minor.
Thanks for guidelines.
Thanks for contributing.
Thank you.
Mirek Suchy
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
--
Marcelo Moreira de Mello
RHCA RHCSS RHCVA
Software Maintenance Engineer/SEG
gpg id: 2048R/FDB110E5
gpg fingerprint: 3BE7 EF71 4DD7 6812 D309 8F18 BD42 D095 FDB1 10E5
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
