On 04/08/2011 02:52 PM, Michael Calmer wrote:
> Hi,
>
> here is the patch to build and run rhnsd on openSUSE.
>
> 0005-changes-to-build-rhnsd-on-SUSE.patch:
> - specfile work
> - provide SUSE init script
Committed. But I have few comments.
I would prefer to have it split to even more commits:
one:
+%if 0%{?suse_version}
+Requires(post): aaa_base
+Requires(preun): aaa_base
+BuildRequires: sysconfig
+%else
with comment:
suse require aaa_base because....
two:
-%setup -q
+%setup -q
removing trailing space
three:
+%dir %{_sysconfdir}/sysconfig/rhn
/etc/sysconfig/rhn/up2date is owned by rhn-client-tools. Since we do not
require them, we should own this directory too.
etc...
While some commits are Suse related, some of them not. So it is not 100%
correct to have it in one commit.
--
Miroslav Suchy
Red Hat Satellite Engineering
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
