Hello,

A documentation review found an issue with the usage information for the 'rhncfg-manager diff' command. There are two parameters there with strange help text.

--dest-file help="Upload the file as this path" . This seems wrong because AFAICS there is no uploading involved with this command, it only diffs files. Besides changing the help text, maybe changing the parameter name to something more meaningful would be good (--remote-file comes to mind, but -r is already used for another option). OTOH, isn't this parameter altogether superfluous as the same functionality is already provided by simply listing multiple files as arguments ("file [ file ... ]")? Is there a policy of having this command's parameters the same as another?

--topdir help="Make all files relative to this string". Here the help text is misleading because there are no new files being made, they are just being compared.

It looks like those two parameters were originally copied from rhncfg_add.py where they are exactly the same, only they make sense for that command.

-Ionuț

_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to