On Tue, May 03, 2011 at 03:19:04PM +0300, Ville Salmela wrote:
>
> these patches and the one already applied
> ba7aa6d770bb76a1368bfcd1bdea4619bce2fad8 fix the remote commands on Spacewalk
> 1.4 and PostgreSQL.
>
> I'm not so sure about the systemlist-rhn-set.patch and rhn-set-db-mixup.patch
> but it works anyway.
>
> They were needed to fix this:
>
>
> > [Mon May 02 10:28:38 2011] [error] Execution of
>
> > /var/www/html/network/systems/ssm/provisioning/remote_command_conf.pxt
>
> > failed at Mon May 2 10:28:38 2011: Can't locate object method "lookup"
>
> > via package "RHN::Set" (perhaps you forgot to load "RHN::Set"?) at
>
> > /usr/lib/perl5/vendor_perl/5.8.8/Sniglets/ListView/SystemList.pm line
>
> > 383.
>
> > [Mon May 02 10:28:38 2011] [error] Traceback sent to
>
> br,
> Ville
> --- RHN/DB/Scheduler.pm.backup 2011-05-02 10:13:04.000000000 +0300
> +++ RHN/DB/Scheduler.pm 2011-05-02 10:47:00.000000000 +0300
> @@ -1511,7 +1511,7 @@
> # can't use the normal add_systems for the set...
> $sth = $dbh->prepare(<<EOQ);
> INSERT INTO rhnServerAction (server_id, action_id, status)
> -SELECT DISTINCT S.id, :action_id, :status
> +SELECT DISTINCT S.id, :action_id + 0, :status + 0
> FROM rhnServer S,
> rhnClientCapabilityName CCN,
> rhnClientCapability CC,
I've applied this one as 3ebe752c01faa2e685e82bf6b59567a682d6ee30.
Thanks!
> --- Sniglets/ListView/SystemList.pm~ 2011-05-02 12:03:28.000000000 +0300
> +++ Sniglets/ListView/SystemList.pm 2011-05-02 12:03:50.000000000 +0300
> @@ -380,7 +380,7 @@
>
> my $earliest_date = Sniglets::ServerActions->parse_date_pickbox($pxt);
>
> - my $system_set = RHN::Set->lookup(-label => 'system_list', -uid =>
> $pxt->user->id);
> + my $system_set = RHN::DB::Set->lookup(-label => 'system_list', -uid =>
> $pxt->user->id);
I don't like this one -- you should not need to avoid the RHN::Set
invocation. If there is something wrong there, it needs to be fixed.
> --- RHN/Set.pm.ORIG 2011-04-29 14:26:22.000000000 +0300
> +++ RHN/Set.pm 2011-05-02 10:42:13.000000000 +0300
> @@ -15,9 +15,9 @@
>
> use strict;
>
> -package RHN::DB::Set;
> +package RHN::Set;
>
> -use RHN::DB;
> +use RHN::DB::Set;
Hmm,
http://git.fedorahosted.org/git/?p=spacewalk.git;a=blob;f=web/modules/rhn/RHN/Set.pm;h=74e4b5c54de1b227dbc96220cffb9c06801d82ed;hb=3ebe752c01faa2e685e82bf6b59567a682d6ee30
shows that the RHN/Set.pm actually has
18 package RHN::Set;
19
20 use RHN::DB::Set;
in it, just like your patch suggests it should. Didn't your .pm's get
a bit broken? You might want to try rpm -Vf on those files.
--
Jan Pazdziora
Principal Software Engineer, Satellite Engineering, Red Hat
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
